Fix memory leak in NSAttributedString #5256
Conversation
| @@ -200,6 +200,14 @@ CFRunArrayRef CFRunArrayCreate(CFAllocatorRef allocator) { | |||
| return array; | |||
| } | |||
|
|
|||
| CFRunArrayRef CFRunArrayRetain(CFRunArrayRef array) { | |||
There was a problem hiding this comment.
Is CFRunArray not a regular CF type? (CFRetain, CFRelease should work)
There was a problem hiding this comment.
The COPY below is just a typedef to CFRetain:
#define COPY(obj) CFRetain(obj)
So yeah I think we can just call CFRetain/CFRelease from NSAttributedString.swift (unless there's an issue with how it's imported by Swift?) and that should be fine.
There was a problem hiding this comment.
When I try to use CFRetain, I get the following error:
'CFRetain' is unavailable: Core Foundation objects are automatically memory managed
There was a problem hiding this comment.
So if it’s automatically memory managed, where is the leak coming from? We don’t have to do this with other CF types.
There was a problem hiding this comment.
My guess is that this is simply not true for non-Darwin platforms.
I’m not sure how this "automatically memory managed" behavior is supposed to work there.
Are there any tests for this?
Currently, all attributes are leaking in
NSAttributedStringThis PR adds proper retain/release handling for
CFRunArrayin the appropriate places.A test was added to validate that attribute values in
NSAttributedStringare no longer leaking.